sch/KaikOut
1
1
Fork 1
Code Issues 18 Pull requests Projects Releases Packages Wiki Activity Actions

main #15

Closed
polymath wants to merge 2 commits from polymath/KaikOut:main into main
pull from: polymath/KaikOut:main
merge into: sch:main
Conversation 1 Commits 2 Files changed 2 +63 -1
polymath commented 2024-10-06 21:16:17 +02:00
First-time contributor
Copy link

This pull request introduces the functionality to send an automated welcome message to users when they join a public room. The goal is to enhance user engagement and provide a more interactive experience upon entering a room.

Give a very harsh review don't accept the Pull request unless it fits you're specifications.

Thanks.

This pull request introduces the functionality to send an automated welcome message to users when they join a public room. The goal is to enhance user engagement and provide a more interactive experience upon entering a room. Give a very harsh review don't accept the Pull request unless it fits you're specifications. Thanks.
polymath added 2 commits 2024-10-06 21:16:17 +02:00
sch commented 2024-11-19 10:19:13 +01:00
Owner
Copy link

Different implementation

I have implemented it differently, using the event mechanism of Slixmpp.

Please. See 39b0cffe66 (diff-c1dfe934c955e8cc97ce11f750665746e651d672)

Also, all JIDs are logged, even upon bot invitation to a new group chat, provided that it can see the JIDs.

This way, only new JIDs be greeted.

Private greetings

Do you want the bot to greet new JIDs, in private?

If so, should the message be delivered directly to the JID or as a private message via the group chat?

### Different implementation I have implemented it differently, using the event mechanism of Slixmpp. Please. See https://git.xmpp-it.net/sch/KaikOut/commit/39b0cffe66f215159e5295456b65ce6618eb1982#diff-c1dfe934c955e8cc97ce11f750665746e651d672 Also, all JIDs are logged, even upon bot invitation to a new group chat, provided that it can see the JIDs. This way, only new JIDs be greeted. ### Private greetings Do you want the bot to greet new JIDs, in private? If so, should the message be delivered directly to the JID or as a private message via the group chat?
sch closed this pull request 2024-11-19 10:19:13 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: sch/KaikOut#15
No description provided.
Delete branch "polymath/KaikOut:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?